fixes False positive with test builder pattern#54
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a false positive issue in the paralleltest linter where test functions using builder patterns to generate test functions were incorrectly flagged as missing parallel calls, even when the returned functions properly called t.Parallel().
- Added support for analyzing function calls that return test functions (builder pattern)
- Enhanced the analyzer to inspect returned function literals for
t.Parallel()calls - Added comprehensive test cases covering both compliant and non-compliant builder patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/paralleltest/paralleltest.go | Implements new logic to handle builder function pattern analysis by adding checkBuilderFunctionForParallel method |
| pkg/paralleltest/testdata/src/t/t_test.go | Adds test cases to verify the fix works correctly for both compliant and non-compliant builder patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if hasParallel { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
This early return check is redundant since the same condition is checked at line 306 with return !hasParallel. The early return here prevents unnecessary traversal once parallel is found, but the logic at line 306 should be return true to continue inspection when parallel is not found.
| if hasParallel { | |
| return false | |
| } |
1 participant
Issue: #50